fix(ios): persist position during page list head changes#1078
Draft
alpha0010 wants to merge 1 commit intocallstack:masterfrom
Draft
fix(ios): persist position during page list head changes#1078alpha0010 wants to merge 1 commit intocallstack:masterfrom
alpha0010 wants to merge 1 commit intocallstack:masterfrom
Conversation
Contributor
Author
|
Discovered a potential issue with this implementation, investigating. |
Contributor
Author
|
So, I am at a bit of a loss. After the following data transition: Page "C" is still correctly the active page, but instead of displaying content, renders blank white. The neighboring pages still render correctly, and if I swipe away and swipe back, "C" will render again. But this error does not occur on initial load, only after using the pager some. Any insights you might have would be greatly appreciated. I feel like I must be missing some fundamental concept, since all my logging and debugging efforts seem to say everything is working as intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dynamic changes to the page list prior to the currently visible page now maintain the same visible page on iOS (this already works on Android).
Fixes #965
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Use the above test screen to add/remove pages before/after the currently visible page. With this PR, iOS should now match the existing Android behavior.
Compatibility
Checklist
README.md